Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make base image parametric. #5880

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

sd3ntato
Copy link
Contributor

default BASE_IMAGE is nvcr.io/nvidia/pytorch:24.02-py3 for retro-compatibility

sd3ntato and others added 2 commits October 30, 2024 21:53
default `BASE_IMAGE` is nvcr.io/nvidia/pytorch:24.02-py3 for retro-compatibility
@hiyouga hiyouga added the solved This problem has been already solved label Nov 2, 2024
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 07e5088 into hiyouga:main Nov 2, 2024
1587causalai pushed a commit to 1587causalai/llama_factory that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants