Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming support w/ audio to Android IP Webcam integration #126009

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

regulad
Copy link

@regulad regulad commented Sep 15, 2024

Breaking change

No breaking changes are made. To users of this integration, the upgrade will be seamless as all devices running Android IP Webcam already support streaming via RTSP.

Proposed change

  • This PR adds support in Home Assistant for Android IP Webcam's RTSP streaming and weighs in at under 20 lines of code.
  • On devices where AAC audio streaming is not supported, like some older devices running KitKat and lower, audio is omitted and a simple H264 stream is used instead.
  • The addition is completely transparent to users of the integration, as the functionality has been in Android IP webcam since the first releases.
  • The added audio support enables different applications of the Android IP Webcam devices where audio is important, like Baby Monitors. I hope this PR helps keep these underutilized devices out of the bin!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally. (PR op note: I tried this on 4 different Android devices, all of them worked as expected (audio where audio is supported, regular stream where it is not))
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works. (PR op note: FFMPEG functionality used is covered by other tests, the tests for android_ip_webcam that test general functionality address all code added in this PR)

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for www.home-assistant.io (PR op note: I think this functionality is pretty self-explanatory and expected, considering that it requires 0 user interaction to activate and work seamlessly I did not make any documentation changes)

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (android_ip_webcam) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of android_ip_webcam can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign android_ip_webcam Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@regulad
Copy link
Author

regulad commented Sep 17, 2024

@engrbm87 @MartinHjelmare how does it look? Any changes?

@frenck frenck force-pushed the feature/android_ip_webcam-stream branch from ab35ba5 to f020834 Compare November 10, 2024 20:17
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 10, 2024
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jan 11, 2025
@regulad
Copy link
Author

regulad commented Jan 11, 2025 via email

@github-actions github-actions bot removed the stale label Jan 13, 2025
@regulad
Copy link
Author

regulad commented Feb 13, 2025

Hey @frenck, I noticed that you added the smash tag. Is there anything else this PR needs before it can be merged? It is a pretty tiny deed, after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants