Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floor_entities function and filter #136509

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Jan 25, 2025

Breaking change

Proposed change

Add floor_entities function & filter to templates to reduce templates like this:

{{['dorm','aanbouw','woongedeelte']|map('floor_areas')|sum(start=[])
            |map('area_entities')|sum(start=[])
            |select('in',label_entities('binnenlamp'))
            |select('is_state','on')|list|sort}}

to this

{{ floor_entities('begane_grond')
            |select('in',label_entities('binnenlamp'))
            |select('is_state','on')|list|sort}}

Relevant WTH -> here

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Petro31 Petro31 requested a review from a team as a code owner January 25, 2025 11:05
@home-assistant home-assistant bot added cla-signed core new-feature WTH Issues & PRs generated from the "Month of What the Heck?" labels Jan 25, 2025
@Petro31 Petro31 changed the title add-floor-entities-function-and-tests Add floor_entities function and filter Jan 25, 2025
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core new-feature smash Indicator this PR is close to finish for merging or closing WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants