Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add climate's swing mode to LG ThinQ #137619

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

LG-ThinQ-Integration
Copy link
Contributor

Proposed change

  • Add swing_mode (air_conditioner)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes#
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review February 7, 2025 05:05
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Feb 20, 2025
@frenck frenck added this to the 2025.3.0b0 milestone Feb 20, 2025
Comment on lines +92 to +102
"swing_mode": {
"state": {
"false": "mdi:arrow-oscillating-off",
"true": "mdi:arrow-oscillating"
}
},
"swing_horizontal_mode": {
"state": {
"false": "mdi:arrow-oscillating-off",
"true": "mdi:arrow-expand-horizontal"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if true and false are proper swing modes. What do each mean? Wouldn't it be the case that you have swing_mode with 3 modes off, horizontal and vertical?

I haven't worked with swing modes a lot, so I might be incorrect, but please let me know what you think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our device provides on(true) and off(false) functions for horizontal and vertical respectively.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but aren't those all 3 swing modes rather than having on and off?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API supports on and off respectively, and according to the developer guide, if the horizontal exists separately, the vertical is instructed to be separated. Do you suggest combining the two into one and implementing it with just swing_mode?

knx's swing_mode example

        if self._device.swing.initialized:
            self._attr_supported_features |= ClimateEntityFeature.SWING_MODE
            self._attr_swing_modes = [SWING_ON, SWING_OFF]

        if self._device.horizontal_swing.initialized:
            self._attr_supported_features |= ClimateEntityFeature.SWING_HORIZONTAL_MODE
            self._attr_swing_horizontal_modes = [SWING_ON, SWING_OFF]

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 21, 2025 12:41
@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review February 24, 2025 00:15
@home-assistant home-assistant bot requested a review from joostlek February 24, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants