implement context.Context

[donseba]

Little "question about" or "request for" context.Context
I know it is something vestigo is not, and probably will implement.

Since you have studied and written about the mainstream mux/routing tools in golang I'd like to know how to implement golang's context.Context or something similar into Vestigo..

This article is pretty clear on how to do it with the default http.Handler but i think it is not very idiomatic.

Would it be possible to do something like goji does ? And limit it to

• func(http.ResponseWriter, *http.Request)
• func(context.Context, http.ResponseWriter, *http.Request)

I have no idea if and how it would influence the performance.

[husobee]

To be honest, the performance would be improved if we implemented a context passing function signature. I have been purposely leaving it out of vestigo for two reasons:

1.) I wanted to stay consistant with the standard lib http.Handler function signature
2.) Future golang versions will eventually support a built in net.Context within the http.Request object

When that future day happens, vestigo will be able to benefit directly, and will improve in performance.

In the mean time, I would suggest using a project like backdrop or gorilla context to allow yourself to access a context across middlewares/handlers.

[husobee]

here is the code review for context in net/http/request.go for 1.7. When go 1.7 comes out, I feel like we should cut a new breaking version of vestigo that utilizes the net/context constructs in the new standard library.

[donseba]

Hi, thanks for the update!!! that looks really promising!! Can't wait to be able to use that!

[josephspurrier]

Have you thought about using build constraints for 1.7 so you don't have to wait?

A good example:
https://github.com/gorilla/csrf/blob/master/context.go
https://github.com/gorilla/csrf/blob/master/context_legacy.go

[husobee]

#41 <- initial attempt at using request context instead of url params

[josephspurrier]

Cool! Looks good to me. I updated my project to use your Param function: blue-jay/blueprint@8e09812

My only suggestion is to move Param, ParamNames, and AddParam into their own files, away from the other code in common.go/common_legacy.go to reduce duplication. Maybe do param.go and param_legacy.go.