Skip to content

Multiple X-Correlation-IDs causing problem #268

Open
@doertydoerk

Description

In this line, an X-Correlation-ID is always added based on the SpanID. Not sure what we need this for, but it can cause problems in scenarios where an X-Correlation-ID is already set beforehand. For instance, tracing tools may get confused as to which ID to follow. That said, going from req.Header.Add() to req.Header.Set() won't fix the problem, as the existing ID would be overwritten and tracing would be corrupted.

IMHO, there should be only one X-Correlation-ID, so at least it should only be set if there isn't one already. Probably even better to not use X-Correlation-ID here and go with another header instead.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions