PointCloudLayer: use view.crs in LasParser (as the other parsers) #2498
Conversation
ftoromanoff
changed the title
ftoromanoff
force-pushed
the
ptCloudReproj
branch
from
bd215e4 to
4508206
Compare
src/Layer/CopcLayer.js
Outdated
| const bounds = [ | ||
| ...forward(cube.slice(0, 3)), | ||
| ...forward(cube.slice(3, 6)), | ||
| ]; | ||
|
|
||
| this.root.bbox.setFromArray(bounds); | ||
|
|
There was a problem hiding this comment.
Could be factorized in parent method
There was a problem hiding this comment.
see previous reply.
ftoromanoff
force-pushed
the
ptCloudReproj
branch
2 times, most recently
from
80bafd6 to
4b75a24
Compare
| const forward = (options.in.crs !== options.out.crs) ? | ||
| proj4(options.in.projDefs, options.out.projDefs).forward : | ||
| (x => x); |
There was a problem hiding this comment.
this is same part with foward, could you factorize ?
There was a problem hiding this comment.
LASLoader will be called by the worker, so we need to limite the dependances, thus it would be counter-productive.
| positions[i * 3] = x - origin[0]; | ||
| positions[i * 3 + 1] = y - origin[1]; | ||
| positions[i * 3 + 2] = z - origin[2]; |
There was a problem hiding this comment.
it's fist transformation to move on local space
There isn't the rotation
src/Parser/LASParser.js
Outdated
| in: { | ||
| crs: options.in.crs, | ||
| projDefs: proj4.defs(options.in.crs), | ||
| }, | ||
| out: { | ||
| crs: options.out.crs, | ||
| projDefs: proj4.defs(options.out.crs), | ||
| }, |
There was a problem hiding this comment.
Factorize with the line 154
There was a problem hiding this comment.
I don't really see the benefit of doing so, moreover when we have the idea (in the futur) to allows proj4.defs as crs. In this cas it will simplifed the options as passing only the crs.
| @@ -231,6 +232,29 @@ class PointCloudLayer extends GeometryLayer { | |||
| this.root = undefined; | |||
| } | |||
|
|
|||
| setRootBbox(min, max) { | |||
There was a problem hiding this comment.
could you the same signature and this
setRootBboxFromArray(bounds)
There was a problem hiding this comment.
If i understand you, you want to add another methode, with a different signature. But currently this function is call 4 times, if we add a 2nd one, both will be called 2 times, won't it be unfactorizing some code ?
ftoromanoff
force-pushed
the
ptCloudReproj
branch
from
4b75a24 to
a564b6e
Compare
ftoromanoff
force-pushed
the
ptCloudReproj
branch
from
a564b6e to
d09e0da
Compare
We use proj4 in LasParser, to projet data in the view.crs during parsing.
A 'elevation' propertie was also added to replace the z data (that is not an elevation)Other minor change: