-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IWF-122: adding set search attributes and set search objects apis #476
Conversation
3d5265d
to
3a48844
Compare
I took a quick look at the code and I don't think you did anything wrong here. The errors on the checks seem to be something to do with the Docker images:
Could be that we're due for some updates, unsure. I'll take a quick look into it to see if it's something with an easy fix |
I suggest starting with running tests locally and seeing if you run into the same issue. I'll do it myself too |
Yes, running locally should reproduce this. However, Docker will cache the downloaded images, and the CI pipelines will always retrieve fresh ones. TLDR: to reproduce locally you need to delete the cached image of This seems to be the cause of the issue: Looking at the tags, it is correct that the tag no longer exists: https://hub.docker.com/r/temporalio/admin-tools/tags - they might've purged them recently |
@samuel27m can you try changing the local variable locally? From |
Doesn't work because the
|
@longquanzheng I'm not sure if we should update the Maybe you know which CLI version we should be on? 🤔 |
Description
Checklist
Related Issue
Closes #issue_number