Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-122: adding set search attributes and set search objects apis #476

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

ktrops
Copy link
Contributor

@ktrops ktrops commented Nov 7, 2024

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@ktrops ktrops force-pushed the jira/katiea/IWF-122 branch from 3d5265d to 3a48844 Compare November 7, 2024 17:13
@samuel27m
Copy link
Member

samuel27m commented Nov 7, 2024

I took a quick look at the code and I don't think you did anything wrong here.

The errors on the checks seem to be something to do with the Docker images:

 temporal-admin-tools Error manifest for temporalio/admin-tools:1.25 not found: manifest unknown: manifest unknown

Could be that we're due for some updates, unsure. I'll take a quick look into it to see if it's something with an easy fix

@lwolczynski
Copy link
Contributor

I suggest starting with running tests locally and seeing if you run into the same issue. I'll do it myself too

@samuel27m
Copy link
Member

Yes, running locally should reproduce this. However, Docker will cache the downloaded images, and the CI pipelines will always retrieve fresh ones.

TLDR: to reproduce locally you need to delete the cached image of temporalio/admin-tools.

This seems to be the cause of the issue:
temporalio/temporal#6052 (comment)

Looking at the tags, it is correct that the tag no longer exists: https://hub.docker.com/r/temporalio/admin-tools/tags - they might've purged them recently

@lwolczynski
Copy link
Contributor

@samuel27m can you try changing the local variable locally? From TEMPORAL_VERSION=1.25 to TEMPORAL_VERSION=1.25.2

@samuel27m
Copy link
Member

samuel27m commented Nov 7, 2024

@samuel27m can you try changing the local variable locally? From TEMPORAL_VERSION=1.25 to TEMPORAL_VERSION=1.25.2

Doesn't work because the temporalio/admin-tools doesn't have that version available. Closest is: 1.25.2-tctl-1.18.1-cli-1.1.1 😕

manifest for temporalio/admin-tools:1.25.2 not found: manifest unknown: manifest unknown 

@samuel27m
Copy link
Member

@longquanzheng I'm not sure if we should update the temporalio/admin-tools tag to 1.25.0-tctl-1.18.1-cli-1.0.0 or to 1.25.0-tctl-1.18.1-cli-1.1.0 to fix the tests here.

Maybe you know which CLI version we should be on? 🤔

@ktrops ktrops merged commit 9973d43 into main Nov 12, 2024
10 checks passed
@ktrops ktrops deleted the jira/katiea/IWF-122 branch November 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants