IWF-364: Fix conditional complete on messages of internalChannels from state APIs #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
commented
Nov 22, 2024
Comment on lines
+79
to
+80
| if p.IsUsingGlobalVersionSearchAttribute() && | ||
| p.workflowProvider.GetBackendType() != service.BackendTypeCadence { |
There was a problem hiding this comment.
this is just some minor cleanup that is not related to this ticket
longquanzheng
commented
Nov 22, 2024
| // There are two cases this is needed: | ||
| // 1. ContinueAsNew: | ||
| // retrieve signals that after signal handler threads are stopped, | ||
| // so that the signals can be carried over to next run by continueAsNew. | ||
| // This includes both regular user signals and system signals | ||
| // 2. Conditional close/complete workflow on signal/internal channel: | ||
| // retrieve all signal/internal channel messages before checking the signal/internal channels | ||
| func (sr *SignalReceiver) DrainAllUnreceivedSignals(ctx UnifiedContext) { | ||
| func (sr *SignalReceiver) DrainAllReceivedButUnprocessedSignals(ctx UnifiedContext) { |
There was a problem hiding this comment.
Rename the method to make it more clear(hopefully)
longquanzheng
changed the title
lwolczynski
approved these changes
Nov 22, 2024
Comment on lines
+492
to
+502
| if versioner.IsAfterVersionOfYieldOnConditionalComplete() { | ||
| // Just yield, by waiting on an empty lambda, nothing else. | ||
| // It will let other workflow threads/coroutines to run. | ||
| // This will drain the messages published from state APIs. | ||
| // NOTE that this is extremely tricky in Cadence/Temporal programming model. | ||
| // Read more: https://stackoverflow.com/questions/71356668/how-does-multi-threading-works-in-cadence-temporal-workflow | ||
| //https://docs.temporal.io/encyclopedia/go-sdk-multithreading | ||
| return provider.Await(ctx, func() bool { | ||
| return true | ||
| }) | ||
| } |
There was a problem hiding this comment.
I'm gonna trust this works as expected. Having tests would be beneficial and make it easier to understand and verify. Hope we can cover multi-threading soon so I can get a better grasp on it.
|
Closes #289 |
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issue
Closes #issue_number