IWF-369: Remove key from map when signal/internal channel is empty #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolczynski
reviewed
Nov 27, 2024
| } | ||
| } | ||
|
|
||
| func (i *InternalChannel) DumpReceived() map[string][]*iwfidl.EncodedObject { |
There was a problem hiding this comment.
Should this be GetReceived?
There was a problem hiding this comment.
👍
I think GetAllReceived maybe more clear and consistent with other GetAll... methods for continueAsNewer to call.
lwolczynski
reviewed
Nov 27, 2024
Comment on lines
10
to
16
| func NewInterStateChannel() *InternalChannel { | ||
| return &InternalChannel{ | ||
| receivedData: map[string][]*iwfidl.EncodedObject{}, | ||
| } | ||
| } | ||
|
|
||
| func RebuildInterStateChannel(refill map[string][]*iwfidl.EncodedObject) *InternalChannel { |
There was a problem hiding this comment.
NewInternalChannel & RebuildInternalChannel?
lwolczynski
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
After
Checklist
Related Issue
Closes #issue_number