-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IWF-274: Optimize Timer creation #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very great job!! this is quite complicated, but I believe it's worth it.
Would be great to add a new test case to it -- especially the idleTimeout pattern, which is that main use case that this optimization is for. Most of the code can be from S1-1 will wait for timer, S1-2 will wait for timer+signal. We can change it to Both S1-1 and S1-2 will wait for signal+timer and only the second timer will fired. We will expect only one timer was started in Temporal. |
4f15ce2
to
b1fef0a
Compare
cf53b87
to
f6fda1b
Compare
Moved interfaces to it's own package. There's a fair amount of IDE refactored code because of this. The main changes to review are
|
f6fda1b
to
fc2d5a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 64.66% 65.70% +1.03%
==========================================
Files 59 62 +3
Lines 6639 6849 +210
==========================================
+ Hits 4293 4500 +207
- Misses 2067 2068 +1
- Partials 279 281 +2 ☔ View full report in Codecov by Sentry. |
e66b879
to
5a35a77
Compare
bde5d80
to
06500dc
Compare
Description
Checklist
Related Issue
Closes #465