Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-546: Add search attributes to IwfEvents #539

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

lwolczynski
Copy link
Contributor

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.69%. Comparing base (91788a0) to head (f558fd9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/interpreter/activityImpl.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   64.56%   64.69%   +0.13%     
==========================================
  Files          59       59              
  Lines        6617     6639      +22     
==========================================
+ Hits         4272     4295      +23     
+ Misses       2066     2065       -1     
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwolczynski lwolczynski marked this pull request as ready for review February 4, 2025 22:14
@lwolczynski lwolczynski merged commit 2d552b8 into main Feb 5, 2025
10 checks passed
@lwolczynski lwolczynski deleted the jira/lwolczynski/IWF-546 branch February 5, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants