Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWF-532: Close integration test workflows when finished #540

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

lwolczynski
Copy link
Contributor

@lwolczynski lwolczynski commented Feb 5, 2025

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #537

@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-532 branch 2 times, most recently from c3d638c to e4f759e Compare February 5, 2025 19:14
@lwolczynski lwolczynski marked this pull request as ready for review February 5, 2025 19:23
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.80%. Comparing base (2d552b8) to head (bed4ac7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   64.66%   65.80%   +1.14%     
==========================================
  Files          59       62       +3     
  Lines        6639     6849     +210     
==========================================
+ Hits         4293     4507     +214     
+ Misses       2067     2063       -4     
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bowersj27 bowersj27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should consider how we might effectively setup and teardown these integ tests' dependent environments in integ/util.go:dostartIwfServiceWithClient to achieve this in the future.

integ/util.go:dostartIwfServiceWithClient AFAICT sets up the iwf process and connection to the backing provider(cadence/temporal) for each test. We may be able to expand on this to track all started wf's and make sure they are closed on each test execution such that we don't have to explicitly add this behavior to each test in the future.

@lwolczynski
Copy link
Contributor Author

LGTM. I think we should consider how we might effectively setup and teardown these integ tests' dependent environments in integ/util.go:dostartIwfServiceWithClient to achieve this in the future.

integ/util.go:dostartIwfServiceWithClient AFAICT sets up the iwf process and connection to the backing provider(cadence/temporal) for each test. We may be able to expand on this to track all started wf's and make sure they are closed on each test execution such that we don't have to explicitly add this behavior to each test in the future.

Opened #542 for it

@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-532 branch from e4f759e to bed4ac7 Compare February 6, 2025 15:54
@lwolczynski lwolczynski enabled auto-merge (squash) February 6, 2025 15:54
@lwolczynski lwolczynski merged commit 8852a80 into main Feb 6, 2025
8 checks passed
@lwolczynski lwolczynski deleted the jira/lwolczynski/IWF-532 branch February 6, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each Integration Test should close their workflows when finished
3 participants