Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitswap/client: fewer wantlist iterations in sendCancels #819

Merged
merged 1 commit into from
Jan 31, 2025
Merged

bitswap/client: fewer wantlist iterations in sendCancels #819

merged 1 commit into from
Jan 31, 2025

Conversation

gammazero
Copy link
Contributor

Combine loops to remove redundant wantlist iteration.

@gammazero
bitswap/client: fewer wantlist iterations in sendCancels
c4590b1 
Combine loops to remove redundant wantlist iteration.
@gammazero gammazero requested a review from a team as a code owner January 29, 2025 01:14
guillaumemichel
guillaumemichel approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was much needed, thanks @gammazero!

@guillaumemichel guillaumemichel merged commit 3c70cf3 into main Jan 31, 2025
14 checks passed
@guillaumemichel guillaumemichel deleted the bitswap-cancel-loops branch January 31, 2025 09:09
@BrewTestBot BrewTestBot mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumemichel guillaumemichel guillaumemichel approved these changes

Assignees
No one assigned
Labels
skip/changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gammazero @guillaumemichel