Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bitswap simplify cancel #824

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix: bitswap simplify cancel #824

merged 2 commits into from
Jan 31, 2025

Conversation

guillaumemichel
Copy link
Contributor

  • refactor to simplify peerWantManager.sendCancels

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (d678ff8) to head (42df060).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   60.40%   60.46%   +0.06%     
==========================================
  Files         244      244              
  Lines       31081    31079       -2     
==========================================
+ Hits        18773    18791      +18     
+ Misses      10628    10611      -17     
+ Partials     1680     1677       -3     
Files with missing lines Coverage Δ
...wap/client/internal/peermanager/peerwantmanager.go 88.25% <100.00%> (-0.09%) ⬇️

... and 13 files with indirect coverage changes

@guillaumemichel guillaumemichel merged commit 62512fb into main Jan 31, 2025
15 checks passed
@guillaumemichel guillaumemichel deleted the bitswap-simplify-cancel branch January 31, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants