Skip to content

Pinning fail bug #1008

Closed
Closed
@jbenet

Description

Found a bug.

  • I pinned a hash:
# i pinned a hash
> ipfs pin add -r <hash>

# pinning failed (context deadline exceeded)

# it ran it again
> ipfs pin add -r <hash>
pinned <hash> recursively
# succeeded immediately

# ran refs just to check
> ipfs refs -r <hash>
<hash1>
<hash2>
<hash3>
<hash4>
<hash5>

# then it got stuck, in the usual "i dont have a ref yet, am fetching it" kind of way
# and proceeded to download more.

THE POINT though, is that ipfs pin add -r <hash> succeeded without all the refs being local


Suggested fix: when adding a recursive pin must check all the refs are there locally. May not need to check the refs themselves, but at least check the object is stored in the repo.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

kind/bugA bug in existing code (including security flaws)topic/commandsTopic commands

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions