Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): allow nofuse builds for MacOS #10135

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix(docker): allow nofuse builds for MacOS #10135

merged 1 commit into from
Sep 22, 2023

Conversation

jmfrank63
Copy link
Contributor

@jmfrank63 jmfrank63 commented Sep 21, 2023 •
edited by lidel
Loading

I am not certain if such a small change needs a changelog, as there is no actual change in the IPFS behaviour.

Closes #10134

@jmfrank63 jmfrank63 requested a review from a team as a code owner September 21, 2023 06:16
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Sep 22, 2023
@lidel lidel changed the title Allow nofuse builds for MacOS with docker solves #10134 [skip changeling] fix(docker): allow nofuse builds for MacOS Sep 22, 2023
lidel
lidel approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for including useful comment 👍

@lidel lidel merged commit 00e26e9 into ipfs:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker should be able to build against different targets than build e.g. nonuse for MacOS builds
2 participants
@jmfrank63 @lidel