-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Basic UnixFS sanity checks #10701
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Abhinav Prakash <[email protected]>
https://docs.ipfs.tech/install/command-line/#system-requirements states 6 GiB, updating readme to match that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
triage note:
- thank you, this is useful, but needs regression test
- @PsychoPunkSage mind adding a test that confirms error occurs when someone tries to copy dag-cbor to MFS? (e.g. empty dag-cbor:
bafyreigbtj4x7ip5legnfznufuopl4sg4knzc2cof6duas4b3q2fy6swua
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggested changes and get CI passing first.
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
Hi @lidel I wrote a test and it is failing ig... currently solving it... Can give some suggestions which might help me
@gammazero Made required changes.... |
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
The test is failing because the type assertion for To test your code, the test needs to create something that is not a |
Signed-off-by: Abhinav Prakash <[email protected]>
Hi @gammazero The Test is
|
This is necessary because a "force" option is already used elsewhere, and its use in multiple places is causing CI to report the error: `Error: option name "force" used multiple times`
@PsychoPunkSage I made 3 additional minor changes. See my 3 commits above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @gammazero |
hi @lidel I think is PR is ready to be merged. |
Raw data
anddag-pb
>no-validate
flag tocmd.options
Closes #10331