feat(AutoTLS): enabled by default with 1h RegistrationDelay #10724
+118
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables AutoTLS by default, but delays registration by 1h if user did not explicitly set `AutoTLS.Enabled` to `true`
lidel
changed the title
hard fail when TCP or Websocket is not present is a bad UX + explodes complexity of tests. instead, we log user-friendly ERROR and disable AutoTLS when there is no /tcp, no Websocket transport, or PNET is used with default settings
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables AutoTLS by default, but delays registration by 1h if user did not explicitly set
AutoTLS.EnabledtotrueDepends on ipshipyard/p2p-forge#58
TODO
AutoTLS.RegistrationDelay=1hAutoTLS.Enabled=falsein test profiledocs/config.mdClose #10560