-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wantlist command #719
wantlist command #719
Conversation
This is a bitswap specific thing. lets put it under
|
07c308c
to
154a17a
Compare
return | ||
} | ||
|
||
res.SetOutput(&KeyList{nd.Exchange.GetWantlist()}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should still cast the exchange to bitswap, as this is a command called bitswap :) -- it probably shouldnt work with non-bitswap exchanges)
@jbenet is this RFM? |
@whyrusleeping can you rebase and push again? looks like travis is still complaining about init docs hash (that got fixed, right?) and, looks like there's a race?
This LGTM, except tests dont seem to be passing |
5c4b02b
to
1af6a62
Compare
The race doesnt appear to be related to the changes in this PR, I filed a bug for it. |
@whyrusleeping what about https://build.protocol-dev.com/job/epic/1257/console ? it ran on cassie-- is that a timeout or oom? |
That appears to be a timeout, looks like the "bitswap no routing" tests can hang... |
This is new though. They weren't hanging before. Could it be the bitswap changes last week? Understand we want to hurry on this PR and ipns but if we let bugs in it will be really hard to squash them later. — On Tue, Feb 24, 2015 at 7:50 PM, Jeromy Johnson [email protected]
|
Yeah, ive seen it twice before. And I think it has happened since my bitswap changes. Ill look into it. |
This is probably caused by my latest bitswap changes, and I think I maybe understand the issue. Ill delve into it more when i get a little more time. |
1af6a62
to
3c8a391
Compare
I wanted to be able to check my wantlist when having trouble resolving things to get a better idea of what was going on. So I made this. not sure what tests to write for it, so if you have any ideas, let me know.