make wantlist updates to connected peers happen async #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM assuming contexts cancel properly. |
|
@whyrusleeping i'd use a waitgroup here. otherwise it wont rate limit |
| if err != nil { | ||
| log.Debugf("Error sending message: %s", err) | ||
| } | ||
| }(p) |
whyrusleeping
force-pushed
the
fix/async-newblocks
branch
from
8a7d281 to
2b16351
Compare
…mproves performance between connected nodes
whyrusleeping
force-pushed
the
fix/async-newblocks
branch
from
2b16351 to
8256b18
Compare
whyrusleeping
added a commit
that referenced
this pull request
Feb 27, 2015
make wantlist updates to connected peers happen async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time debugging why the gateway nodes have been slow recently, and it came down to these sends taking a long time for certain peers. Since bitswap uses a routed peerhost, I think that some peers in the ledger werent connected to, and it was maybe trying to reconnect to them to send them a message.