Feature: Memory Banks (Windows Only) #162
Conversation
memory.go
Outdated
| @@ -11,9 +11,19 @@ import ( | |||
| "math" | |||
| ) | |||
|
|
|||
| type MemoryBank struct { | |||
| Name string `json:"name"` | |||
There was a problem hiding this comment.
Let's go ahead and remove the Name field. I don't think it adds anything over the Label and Location fields.
memory.go
Outdated
| @@ -11,9 +11,19 @@ import ( | |||
| "math" | |||
| ) | |||
|
|
|||
| type MemoryBank struct { | |||
There was a problem hiding this comment.
Let's call this MemoryModule, to align with industry terminology:
https://en.wikipedia.org/wiki/Memory_module
I know CIM/WMI uses the term "bank", but generally these things are referred to as "modules" in my experience :)
memory_windows.go
Outdated
| @@ -21,12 +21,49 @@ type win32OperatingSystem struct { | |||
| TotalVisibleMemorySize uint64 | |||
| } | |||
|
|
|||
| const wmqlPhysicalMemor = "SELECT BankLabel, Capacity, DataWidth, Description, DeviceLocator, Manufacturer, Model, Name, PartNumber, PositionInRow, SerialNumber, Speed, Tag, TotalWidth FROM Win32_PhysicalMemory" | |||
There was a problem hiding this comment.
Missing "y" at the end of the above variable name :)
| PartNumber string | ||
| PositionInRow uint32 | ||
| SerialNumber string | ||
| Speed uint32 |
There was a problem hiding this comment.
In a future PR (not this one), I'd be interested in adding a Speed field to the MemoryModule struct. Need to have a conversation about what the appropriate data type is, though, so let's leave that for a future commit.
memory_windows.go
Outdated
| SizeBytes: int64(description.Capacity), | ||
| Vendor: description.Manufacturer, | ||
| }) | ||
| //totalPhysicalBytes += description.Capacity |
|
As soon as I'll get back from my travels, I'll follow the suggestions |
Collecting the correct product UUID
Using private win32 structs and static vmi queries
Added partial windows support to cpu and memory Issue jaypipes#8
Added partial windows support to block
When collecting HW informations about memory, it's also very usefull to know the physical memory banks and their specs
jaypipes
force-pushed
the
win_memory_feature_banks
branch
from
3f5dd4f to
f90bcd9
Compare
When collecting HW informations about memory, it's also very usefull to know the physical memory banks and their specs
Quick example:
