Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make strong SKPSMTPMessageDelegate's instance #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make strong SKPSMTPMessageDelegate's instance #13

wants to merge 1 commit into from

Conversation

novalagung
Copy link

I always got an error while using the latest version of skpsmtpmessage. the error message is [SKPSMTPMessage setWatchdogTimer:]: message sent to de allocated instance. The error is showing when skpsmtp try to invoke implemented delegate.

I try to make SKPSMTPMessageDelegate's instance in SKPSMTPMessage.h to strong and solve this problem.

@brokaw
Copy link
Contributor

brokaw commented Feb 11, 2014

This might fix your crash, but it will often result in retain cycles and memory leaks. We can update the delegate to a weak property, which will zero it out and prevent crashes. That will fix the symptom, if not the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants