Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetEntry / MLST for some servers - Fixes #321 #322

Merged
merged 1 commit into from
May 13, 2023

Conversation

ncw
Copy link
Contributor

@ncw ncw commented Mar 28, 2023

Some servers seem to send a blank line at the end of an MLST response.

MLST Download
250-
Size=53248;Modify=20230327134339.000;Type=dir; Download

250 Requested file action okay, completed.

Before this change this would cause the GetEntry method to return this error.

unsupported LIST line

This patch ignores blank lines in the MLST response.

@coveralls
Copy link

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 72.577% (+0.06%) from 72.521% when pulling 1a07078 on rclone:fix-MLST-blank-line into d84bf4b on jlaffaye:master.

@ncw ncw force-pushed the fix-MLST-blank-line branch from e18ac5c to e3e5660 Compare March 28, 2023 06:52
Some servers seem to send a blank line at the end of an MLST response.

    MLST Download
    250-
    Size=53248;Modify=20230327134339.000;Type=dir; Download

    250 Requested file action okay, completed.

Before this change this would cause the GetEntry method to return this
error.

    unsupported LIST line

This patch ignores blank lines in the MLST response.
@ncw ncw force-pushed the fix-MLST-blank-line branch from e3e5660 to 1a07078 Compare March 28, 2023 07:00
@jlaffaye jlaffaye merged commit 36e873b into jlaffaye:master May 13, 2023
@ncw ncw deleted the fix-MLST-blank-line branch June 10, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants