-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Remove alt-text for menuItem with image and title #40675
Conversation
LGTM |
Co-authored-by: Quy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When |
No, as there is the menu item text , but hidden for sighted users |
But this is not the case as seen below:
|
Thank you for testing - will fix this asap |
I have tested this item ✅ successfully on b63b611 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675. |
This pull request has been automatically rebased to 4.4-dev. |
This one here is not RTC, it has only one test. |
Back to pending as it has only one test This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675. |
I have tested this item ✅ successfully on 87b1361 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675. |
Change order of classes Co-authored-by: Quy <[email protected]>
Change order of classes Co-authored-by: Quy <[email protected]>
This pull request has been automatically rebased to 5.2-dev. |
I have tested this item ✅ successfully on 731bba0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675. |
Pull Request for Issue # .
Summary of Changes
In the menu layouts menus can have an image followed by an text. Alt-text for images are generated equal to the menuitem title. If the menutype is a link, this is an a11y issue, in other cases it is useless.
This PR replaces the alt text by an empty alt-text for all menutypes.
Testing Instructions
Code inspect and sourcecode inspect.
Or use a tool like IBM accessible audit in your browser and check your menus with images.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[x No documentation changes for manual.joomla.org needed