-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] [Events] Use event classes for System plugins #43637
Conversation
@Fedik System tests are failing in Drone when trying to delete a user and waiting for the content "User deleted." appearing in the in the system-message-container div. |
This pull request has been automatically rebased to 5.3-dev. |
Conflicts: plugins/system/highlight/src/Extension/Highlight.php
Conflicts: plugins/system/actionlogs/src/Extension/ActionLogs.php
Conflicts: plugins/system/jooa11y/src/Extension/Jooa11y.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are needed. Some changes are nice to have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some other small changes and we should be fine. Thanks !
Thanks, all good now from my code review and basic test. |
Summary of Changes
Update
system
plugins to useSubscriberInterface
and event classes.Testing Instructions
Check following
system
plugins should work as before:Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: