Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] [Events] Use event classes for System plugins #43637

Merged
merged 29 commits into from
Feb 5, 2025

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 8, 2024

Summary of Changes

Update system plugins to use SubscriberInterface and event classes.

Testing Instructions

Check following system plugins should work as before:

accessibility
actionlogs
fields
highlight
jooa11y
languagecode
log
privacyconsent
remember
skipto
stats

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: New Event classes Manual#177
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added the Feature label Jun 8, 2024
@Fedik Fedik marked this pull request as draft June 8, 2024 16:46
@Fedik Fedik marked this pull request as ready for review June 9, 2024 11:17
@richard67
Copy link
Member

@Fedik System tests are failing in Drone when trying to delete a user and waiting for the content "User deleted." appearing in the in the system-message-container div.

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2][Events] Use event classes for System plugins [5.3] [Events] Use event classes for System plugins Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
 Conflicts:
	plugins/system/highlight/src/Extension/Highlight.php
Fedik and others added 4 commits January 18, 2025 12:07
 Conflicts:
	plugins/system/actionlogs/src/Extension/ActionLogs.php
 Conflicts:
	plugins/system/jooa11y/src/Extension/Jooa11y.php
Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are needed. Some changes are nice to have

Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some other small changes and we should be fine. Thanks !

@joomdonation
Copy link
Contributor

Thanks, all good now from my code review and basic test.

@laoneo laoneo enabled auto-merge (squash) February 5, 2025 15:41
@laoneo laoneo added this to the Joomla! 5.3.0 milestone Feb 5, 2025
@laoneo laoneo merged commit 6dd79ee into joomla:5.3-dev Feb 5, 2025
3 checks passed
@Fedik Fedik deleted the plg-event-system branch February 5, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants