[5.2]postgres and finder suggestions

[alikon]

Pull Request for Issue #44373
.

Summary of Changes

rewrite the query

Testing Instructions

create content with few words
be sure it indexed by Smart search component
add module Smart search to site
type word into search edit

Actual result BEFORE applying this Pull Request

No suggestions

Expected result AFTER applying this Pull Request

suggestions

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

The change of this PR here is right.

We could insist now on quoteNames being used and so on, but that would not be consistent with the other code in that file where it is not used either at all places, and cleaning that up would be out of scope of this PR here.

[softarius]

It works for me in Postgresql 16.4, MySQL 8 and MariaDB 5.6
@richard67 I'm asking you to merge this PR

[richard67]

It works for me in Postgresql 16.4, MySQL 8 and MariaDB 5.6 @richard67 I'm asking you to merge this PR

@softarius Could you mark your test result in the issue tracker https://issues.joomla.org/tracker/joomla-cms/44384 by using the blue "Test this" button at the top left corner, select your test result (success) and submit? Every non-trivial PR needs 2 successful human tests, and when you mark your test result 50% is done. Thanks in advance.

[softarius]

I have tested this item ✅ successfully on 840858f

Suceessfully tested in Postgresql 16.4, MySQL 8 and MariaDB 5.6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44384.}

[richard67]

@softarius Thanks for testing. Unfortunately I think this PR might not be in time for the upcoming 5.2.2 because packages for that version are already in preparation for being tested by the CMS Release Team, so it would be the next version after that, 5.2.3, which is planned for January 7, 2025. Not my responsibility or decision, I only report what I know. I will try my best to bring this PR forward, but I can't promise that it will help to bring it into 5.2.2.

[richard67]

I have tested this item ✅ successfully on 840858f

Tested with PostgreSQL 16.4 and MySQL 8.0.40.

With PostgreSQL 16 without this PR in /var/log/postgresql/postgresql-16-main.log:

2024-11-23 14:17:20.339 CET [5520] jdb2adm@joomladb2 ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list at character 288
2024-11-23 14:17:20.339 CET [5520] jdb2adm@joomladb2 STATEMENT:  SELECT DISTINCT(t.term)
	FROM "#__finder_terms" AS "t"
	INNER JOIN "#__finder_links_terms" AS "tm" ON tm.term_id = t.term_id
	INNER JOIN "#__finder_links" AS "l" ON (tm.link_id = l.link_id)
	WHERE t.term_id IN ($1) AND l.access IN (1,5) AND l.state = 1 AND l.published = 1
	ORDER BY t.links DESC,t.weight DESC LIMIT 10

With this PR no such log, and finder suggestions are shown.

With MySQL 8.0 with this PR it works as well as without this PR.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44384.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44384.}

[Hackwar]

Thank you for your contribution!