Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Updating wamania/php-stemmer to 4.0.0 #44657

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Dec 22, 2024

Partial Pull Request for Issue #44504. (DO NOT CLOSE ORIGINAL ISSUE)

Summary of Changes

wamania/php-stemmer depended on voku/portable-utf8 which seems to have been abandoned and also is a gigantic library. Coincidentally, our joomla/string package has all necessary features for the stemmer, so wamania accepted a PR to switch to our library instead. This PR updates our dependency to version 4.0. Since we unfortunately still have the hard requirement for voku/portable-utf8 in our composer.json, this doesn't change anything in codesize, but it does help with the notices being thrown in PHP 8.4.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@rdeutz
Copy link
Contributor

rdeutz commented Jan 10, 2025

This was discussed in the maintainer meeting and is implementing the change we discussed.

@rdeutz rdeutz self-requested a review January 10, 2025 11:01
@Hackwar
Copy link
Member Author

Hackwar commented Jan 25, 2025

Conflict has been fixed.

@laoneo laoneo merged commit 95fc2cb into joomla:5.3-dev Jan 27, 2025
3 checks passed
@laoneo
Copy link
Member

laoneo commented Jan 27, 2025

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Jan 27, 2025
@laoneo
Copy link
Member

laoneo commented Jan 27, 2025

Can you document this in the manual. @HLeithner can tell you exactly in which document.

@Hackwar
Copy link
Member Author

Hackwar commented Jan 27, 2025

What do we need to document here? There is no difference between the old and new version from our perspective, since we are still shipping with the utf8 library and the only difference between the stemmer version 3 and 4 is, that 4 uses our Joomla String framework class. I don't see what benefit an entry for this in the manual would have.

@Hackwar Hackwar deleted the 5.3-phpstemmer branch January 27, 2025 08:40
@HLeithner
Copy link
Member

It might be useful to document all updates on direct dependencies.

@laoneo
Copy link
Member

laoneo commented Jan 27, 2025

Agree here with Harald, we should at least document the major dependency upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants