Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix missing brackets #44739

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[5.2] Fix missing brackets #44739

merged 2 commits into from
Jan 17, 2025

Conversation

janschoenherr
Copy link
Contributor

Fixed missing brackets

Testing Instructions

Nothing

Actual result BEFORE applying this Pull Request

Probably broken version string

Expected result AFTER applying this Pull Request

Correct version string

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@SumCompanyInc
Copy link

I have tested this item ✅ successfully on 66ac320

appears the patch has applied the missing brackets.
screenshot of code after patch applied


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

@Agapiiii
Copy link

I also tested it, the patch applied the missing brackets.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

@Agapiiii
Copy link

I have tested this item ✅ successfully on 66ac320

I also tested it, the patch applied the missing brackets.Code Update


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

@imejine
Copy link

imejine commented Jan 17, 2025

I have tested this item ✅ successfully on 66ac320

tested, it works.
before and after


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

@QuyTon
Copy link
Contributor

QuyTon commented Jan 17, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44739.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 17, 2025
@Hackwar Hackwar merged commit 276c7a1 into joomla:5.2-dev Jan 17, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 17, 2025
@Hackwar Hackwar added this to the Joomla! 5.2.4 milestone Jan 17, 2025
@Hackwar
Copy link
Member

Hackwar commented Jan 17, 2025

Thank you!

@heelc29
Copy link
Contributor

heelc29 commented Jan 18, 2025

@janschoenherr What about line 835?

@janschoenherr janschoenherr mentioned this pull request Jan 18, 2025
4 tasks
@janschoenherr
Copy link
Contributor Author

@janschoenherr What about line 835?

Thanks, I did another PR: #44742

@janschoenherr janschoenherr deleted the patch-22 branch February 11, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants