Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Convert mod_privacy_status to service provider #44752

Merged
merged 13 commits into from
Feb 8, 2025

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the privacy status module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_privacy_status published
  2. You should see module output

mod_privacy_status

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Jan 19, 2025

I have tested this item ✅ successfully on bde9420

Module looks before and after Pull Request same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752.

Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some suggestions for better method names (I hope) and it should be ready for testing. Thanks !

Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, still more changes are needed. Please look at it and implement the change when you have time. Thanks !

@joomdonation
Copy link
Contributor

Thanks @joomlaweby. It is all good now. @fgsw Could you please test it again? Thanks.

@joomlaweby
Copy link
Contributor Author

@joomdonation great! Thanks for review!

@fgsw
Copy link

fgsw commented Jan 27, 2025

I have tested this item ✅ successfully on a7561c3

Before PR After PR
1 2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on a7561c3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752.

@joomdonation
Copy link
Contributor

RTC. Thanks @joomlaweby for your work and thanks @fgsw and @viocassel for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 4, 2025
@joomlaweby
Copy link
Contributor Author

RTC. Thanks @joomlaweby for your work and thanks @fgsw and @viocassel for testing.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44752.

Thanks to everybody!

@richard67 richard67 merged commit a32ee0a into joomla:5.3-dev Feb 8, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 8, 2025
@richard67 richard67 added this to the Joomla! 5.3.0 milestone Feb 8, 2025
@richard67
Copy link
Member

Thank you.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 8, 2025
LadySolveig pushed a commit that referenced this pull request Feb 16, 2025
…#44838)

* Add deleted files from PR #44812
* Add deleted file from PR #44752
* Add deleted file from PR #44819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants