[deb] The regex for valid package names in relationships does not allow names including "." (and is missing a couple of constraints) #1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian policy is that package names may include a period, and this is used for a number of default packages (for instance,
ruby2.7
).Binary package documentation points to the Source package docs:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-package
Source package documentation includes ".":
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-source
Current text:
The regex in
fpm/lib/fpm/package/deb.rb
Line 41 in 7881705
does not correctly apply the rules, as it does not allow "." or apply the alphanumeric and minimum-two-character limits.