Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aroma.js.org #9596

Merged
merged 2 commits into from
Feb 22, 2025
Merged

aroma.js.org #9596

merged 2 commits into from
Feb 22, 2025

Conversation

aaveshdev
Copy link
Contributor

@aaveshdev aaveshdev commented Feb 21, 2025

The site content is documentation, installation and use features of Aroma.js (a lightweight web framework for node.js)

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Feb 21, 2025
@aaveshdev
Copy link
Contributor Author

added aroma.js.org in Pages, custom domain settings

@aaveshdev aaveshdev requested a review from MattIPv4 February 21, 2025 21:44
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/aaveshdev/aroma.js-website

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Feb 21, 2025
@indus
Copy link
Member

indus commented Feb 22, 2025

Welcome https://aroma.js.org

@indus indus merged commit 615b8b9 into js-org:master Feb 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants