Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Etag from OBS #1715

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Verify Etag from OBS #1715

merged 3 commits into from
Apr 6, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 2, 2022

We have experienced data loss from OBS silently, so we should double check the returned ETag from OBS.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #1715 (776c550) into main (f55ba44) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

❗ Current head 776c550 differs from pull request most recent head 3562b2f. Consider uploading reports for the commit 3562b2f to get more accurate results

@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   61.70%   61.55%   -0.16%     
==========================================
  Files         134      135       +1     
  Lines       22721    22883     +162     
==========================================
+ Hits        14020    14085      +65     
- Misses       7126     7198      +72     
- Partials     1575     1600      +25     
Impacted Files Coverage Δ
pkg/object/obs.go 0.95% <0.00%> (-0.04%) ⬇️
pkg/fuse/context.go 56.75% <0.00%> (-10.82%) ⬇️
pkg/vfs/reader.go 77.18% <0.00%> (-7.49%) ⬇️
pkg/chunk/cached_store.go 77.36% <0.00%> (-1.15%) ⬇️
pkg/meta/base.go 71.18% <0.00%> (-0.51%) ⬇️
pkg/meta/utils.go 71.18% <0.00%> (-0.49%) ⬇️
pkg/meta/sql.go 66.92% <0.00%> (-0.21%) ⬇️
pkg/meta/tkv_etcd.go 77.77% <0.00%> (ø)
pkg/meta/tkv.go 76.55% <0.00%> (+0.02%) ⬆️
pkg/meta/tkv_prefix.go 96.61% <0.00%> (+0.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55ba44...3562b2f. Read the comment docs.

@davies davies changed the title Verify etag from OBS Verify Etag from OBS Apr 6, 2022
@davies davies merged commit dddb323 into main Apr 6, 2022
@davies davies deleted the verify_etag branch April 6, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants