fix(router): associate parent payment token with payment_method_id as hyperswitch token for saved cards
#2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hyperswitch token for cards
vspecky
added
C-bug
vspecky
requested review from
inventvenkat,
jarnura,
Sangamesh26,
Sarthak1799 and
ShankarSinghC
…g card from permanent locker
jarnura
requested changes
Sep 18, 2023
jarnura
previously approved these changes
Sep 20, 2023
Sarthak1799
previously approved these changes
Sep 20, 2023
Sarthak1799
reviewed
Oct 12, 2023
Sarthak1799
previously approved these changes
Oct 12, 2023
jarnura
previously approved these changes
Oct 17, 2023
…rename all variants to snake case
|
Test Case :-
|
|
Could you resolve the conflicts on the linked PR? |
jarnura
approved these changes
Nov 16, 2023
Sarthak1799
approved these changes
Nov 20, 2023
SanchithHegde
removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR implements some missing components of #2073 , mainly the logic to associate the generated parent payment token with the
payment_method_idas opposed to a randomly generated temp locker token in the saved cards flow, so a call can be made directly to the persistent locker to fetch card details.Additional Changes
None
Motivation and Context
Due to the missing association between parent payment token and the payment method id as hyperswitch token for saved cards, the saved cards flow had some potential issues which needed to be addressed.
How did you test it?
Local testing of happy flows and edge cases, compiler-guided.
Checklist
cargo +nightly fmt --allcargo clippy