feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

Sakilmostak · 2023-11-20T17:43:18Z

Type of Change

Description

Card token is being saved in metadata to later use for refund
Void flow have been removed with prophetpay doesn't have capture
Refactor of Rsync
Minor refactor for the comments given in previous PR for prophetpay

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Refund was not working before because card token was not stored to retrieve the payemnt, now both Refund and Rsync can be tested after making the payment.
These two are the scenario for the payments:
Success Case:
{ "amount": 10000, "currency": "USD", "confirm": true, "amount_to_capture": 10000, "business_country": "US", "customer_id": "custhype1232", "return_url": "https://www.google.com", "payment_method": "card_redirect", "payment_method_type": "card_redirect", "payment_method_data": { "card_redirect": { "card_redirect": {} } }, "routing": { "type": "single", "data": "prophetpay" } }
This will have the response as this after Psync:
{ "payment_id": "pay_IcWrOgd5iKOecC4sY9bH", "merchant_id": "merchant_1700580874", "status": "succeeded", "amount": 10000, "amount_capturable": 0, "amount_received": 10000, "connector": "prophetpay", "client_secret": "pay_IcWrOgd5iKOecC4sY9bH_secret_2pVdz9TgeocWDeNbQlJP", "created": "2023-11-21T15:37:23.172Z", "currency": "USD", "customer_id": "custhype1232", "description": null, "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": null, "payment_method": "card_redirect", "payment_method_data": "card_redirect", "payment_token": null, "shipping": null, "billing": null, "order_details": null, "email": null, "name": null, "phone": null, "return_url": "https://www.google.com/", "authentication_type": null, "statement_descriptor_name": null, "statement_descriptor_suffix": null, "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "payment_experience": null, "payment_method_type": "card_redirect", "connector_label": "prophetpay_US_default", "business_country": "US", "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": null, "manual_retry_allowed": false, "connector_transaction_id": "2226270406", "frm_message": null, "metadata": null, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_ThBc5yMoyMfNM7A5UFyk", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_3DGrmnIoL1C1sxBiwbgY" }
Failure Case:
{ "amount": 3000, "currency": "USD", "confirm": true, "amount_to_capture": 3000, "business_country": "US", "customer_id": "custhype1232", "return_url": "https://www.google.com", "payment_method": "card_redirect", "payment_method_type": "card_redirect", "payment_method_data": { "card_redirect": { "card_redirect": {} } }, "routing": { "type": "single", "data": "prophetpay" } }
This will have the response as this after Psync:
{ "payment_id": "pay_tzos8jBhICTXIg7sV0EM", "merchant_id": "merchant_1700580874", "status": "failed", "amount": 3000, "amount_capturable": 0, "amount_received": null, "connector": "prophetpay", "client_secret": "pay_tzos8jBhICTXIg7sV0EM_secret_elchmW7r3lf7900110Fi", "created": "2023-11-21T15:34:47.070Z", "currency": "USD", "customer_id": "custhype1232", "description": null, "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": null, "payment_method": "card_redirect", "payment_method_data": "card_redirect", "payment_token": null, "shipping": null, "billing": null, "order_details": null, "email": null, "name": null, "phone": null, "return_url": "https://www.google.com/", "authentication_type": null, "statement_descriptor_name": null, "statement_descriptor_suffix": null, "next_action": null, "cancellation_reason": null, "error_code": "1025", "error_message": "Transaction declined - call issuer", "payment_experience": null, "payment_method_type": "card_redirect", "connector_label": "prophetpay_US_default", "business_country": "US", "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": null, "manual_retry_allowed": true, "connector_transaction_id": null, "frm_message": null, "metadata": null, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": null, "profile_id": "pro_ThBc5yMoyMfNM7A5UFyk", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_3DGrmnIoL1C1sxBiwbgY" }

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

crates/router/src/connector/prophetpay.rs

crates/router/src/connector/prophetpay/transformers.rs

ArjunKarthik · 2023-11-21T11:35:57Z

crates/router/src/connector/prophetpay.rs

-    ) -> CustomResult<ErrorResponse, errors::ConnectorError> {
-        self.build_error_response(res)
-    }
+    // fn get_headers(


Use multiline comment

ArjunKarthik · 2023-11-21T11:41:36Z

crates/router/src/connector/prophetpay.rs

+    //     Ok(Some(prophetpay_req))
+    // }
+
+    // fn build_request(


Keep the build_request method uncommented and throw errors::ConnectorError::NotImplemented with error message as "Void flow not implemented"

ArjunKarthik · 2023-11-21T11:43:09Z

crates/router/src/connector/prophetpay/transformers.rs

+        let connector_metadata = serde_json::to_value(card_token_data).ok();
+
+        Ok(Self {
+            status: enums::AttemptStatus::from(item.response.response_text),


in case of payment failure we need to capture the error message, code and reason

ArjunKarthik · 2023-11-21T11:43:47Z

crates/router/src/connector/prophetpay/transformers.rs

+        item: types::ResponseRouterData<F, ProphetpaySyncResponse, T, types::PaymentsResponseData>,
+    ) -> Result<Self, Self::Error> {
+        Ok(Self {
+            status: enums::AttemptStatus::from(item.response.response_text),


in case of payment failure we need to capture the error message, code and reason

ArjunKarthik · 2023-11-21T11:44:22Z

crates/router/src/connector/prophetpay/transformers.rs

+            status: enums::AttemptStatus::from(item.response.response_text),
+            response: Ok(types::PaymentsResponseData::TransactionResponse {
+                resource_id: types::ResponseId::ConnectorTransactionId(
+                    item.response.transaction_id,


Are we getting same transaction_id in payments and retrieve payments?

ArjunKarthik · 2023-11-21T11:47:17Z

crates/router/src/connector/prophetpay/transformers.rs

@@ -435,8 +594,8 @@ impl TryFrom<&types::PaymentsCancelRouterData> for ProphetpayVoidRequest {
        let transaction_id = item.request.connector_transaction_id.to_owned();
        Ok(Self {
            transaction_id,
-            ref_info: item.attempt_id.to_owned(),
-            inquiry_reference: format!("inquiry_{}", item.attempt_id),
+            ref_info: item.connector_request_reference_id.to_owned(),


If payments api accepts same value for ref_info and inquiry_reference, then lets pass connector_request_reference_id in both the fields

No, ref_info and inquiry_reference cant have same value

ArjunKarthik · 2023-11-21T11:48:06Z

crates/router/src/connector/prophetpay/transformers.rs

+                card_token: card_token_data.card_token,
+                profile: auth_data.profile_id,
+                ref_info: item.router_data.request.refund_id.to_owned(),
+                inquiry_reference: format!("inquiry_{}", item.router_data.request.refund_id),


If refunds api accepts same value for ref_info and inquiry_reference, then lets pass refund_id in both the fields

No, ref_info and inquiry_reference cant have the same value

crates/router/src/connector/prophetpay/transformers.rs

ArjunKarthik · 2023-11-21T12:03:35Z

crates/router/src/connector/prophetpay/transformers.rs

+            response: Ok(types::RefundsResponseData {
+                // no refund id is generated, rather transaction id is used for referring to status in refund also
+                connector_refund_id: item.data.request.connector_transaction_id.clone(),
+                refund_status: enums::RefundStatus::from(item.response.response_text),


incase of refund failure, capture error message, reason, code

ArjunKarthik · 2023-11-21T12:03:51Z

crates/router/src/connector/prophetpay/transformers.rs

@@ -520,17 +695,75 @@ impl TryFrom<types::RefundsResponseRouterData<api::Execute, ProphetpayRefundResp
        Ok(Self {
            response: Ok(types::RefundsResponseData {
                // no refund id is generated, rather transaction id is used for referring to status in refund also
-                connector_refund_id: item.data.request.connector_transaction_id.clone(),
+                connector_refund_id: item.response.tran_seq_number,
                refund_status: enums::RefundStatus::from(item.response.response_text),


incase of refund failure, capture error message, reason, code

ArjunKarthik · 2023-11-21T14:08:10Z

crates/router/src/connector/prophetpay/transformers.rs

+            Ok(Self {
+                response: Ok(types::RefundsResponseData {
+                    // no refund id is generated, rather transaction id is used for referring to status in refund also
+                    connector_refund_id: item.data.request.connector_transaction_id.clone(),


This will overwrite the tran_seq_number which we are setting in the refund flow. Keep the connector_refund_id here. Take this in separate PR

Sakilmostak added 3 commits November 20, 2023 18:38

refactor: seperate try_from for each flow

0239d79

refactor: remove void flow

42745c9

feat: save card token in metadata

2a12332

Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Nov 20, 2023

Sakilmostak self-assigned this Nov 20, 2023

Sakilmostak requested a review from a team as a code owner November 20, 2023 17:43

refactor: remove validation used for testing

4fe1325

ArjunKarthik requested changes Nov 21, 2023

View reviewed changes

crates/router/src/connector/prophetpay.rs Outdated Show resolved Hide resolved

crates/router/src/connector/prophetpay/transformers.rs Outdated Show resolved Hide resolved

crates/router/src/connector/prophetpay/transformers.rs Outdated Show resolved Hide resolved

refactor: void flow and reference id

bf76dc5

ArjunKarthik requested changes Nov 21, 2023

View reviewed changes

ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Nov 21, 2023

Sakilmostak added 2 commits November 21, 2023 19:27

refactor: comments

eb745a7

refactor: clippy errors

631f48e

ArjunKarthik approved these changes Nov 21, 2023

View reviewed changes

ArjunKarthik reviewed Nov 21, 2023

View reviewed changes

Sakilmostak requested review from deepanshu-iiitu and Gnanasundari24 November 21, 2023 14:08

deepanshu-iiitu approved these changes Nov 21, 2023

View reviewed changes

Merge branch 'main' into prop_pay_add

d565e7d

Gnanasundari24 added this pull request to the merge queue Nov 21, 2023

Merged via the queue into main with commit 15a255e Nov 21, 2023

Gnanasundari24 deleted the prop_pay_add branch November 21, 2023 16:11

SanchithHegde removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

Sakilmostak commented Nov 20, 2023 •

edited

Loading

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

Sakilmostak Nov 21, 2023

ArjunKarthik Nov 21, 2023

Sakilmostak Nov 21, 2023

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

ArjunKarthik Nov 21, 2023

feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

Conversation

Sakilmostak commented Nov 20, 2023 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sakilmostak commented Nov 20, 2023 •

edited

Loading