fix: validate refund amount with amount_captured instead of amount #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
the
S-waiting-on-review
hrithikesh026
requested review from
SanchithHegde,
Narayanbhat166 and
Gnanasundari24
Narayanbhat166
previously approved these changes
Dec 13, 2023
sai-harsha-vardhan
previously approved these changes
Dec 13, 2023
|
@hrithikesh026 Can you add the same cases in postman aswell |
hrithikesh026
dismissed stale reviews from sai-harsha-vardhan and Narayanbhat166
via
2283fe9
Gnanasundari24
approved these changes
Dec 13, 2023
sai-harsha-vardhan
approved these changes
Dec 13, 2023
Narayanbhat166
approved these changes
Dec 13, 2023
ThisIsMani
approved these changes
Dec 13, 2023
Gnanasundari24
deleted the
refund-amount-validation-with-amount-captured
branch
lsampras
pushed a commit
that referenced
this pull request
Dec 15, 2023
SanchithHegde
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refund amount was being validated with amount field in payment_attempt.
In fact it should be validated with amount_captured field in payment_intent.
Because refund can only be made with amount that has already being captured.
Additional Changes
How did you test it?
Manual
Partially captured payment
Refund with refund_amount greater than amount_recieved(amount_captured)
Refund with refund_amount less than amount_recieved.
Checklist
cargo +nightly fmt --allcargo clippy