-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store payment check codes and authentication data from processors #3958
Merged
Gnanasundari24
merged 31 commits into
main
from
4229-feature-store-payment-check-codes-and-authentication-data-from-processors
Mar 20, 2024
Merged
feat: store payment check codes and authentication data from processors #3958
Gnanasundari24
merged 31 commits into
main
from
4229-feature-store-payment-check-codes-and-authentication-data-from-processors
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4320-refactor-pass-payment_method_billing-to-connector-module
Base automatically changed from
4320-refactor-pass-payment_method_billing-to-connector-module
to
main
March 12, 2024 10:38
…uthentication-data-from-processors
…uthentication-data-from-processors
hrithikesh026
previously approved these changes
Mar 18, 2024
sai-harsha-vardhan
previously approved these changes
Mar 18, 2024
sahkal
previously approved these changes
Mar 18, 2024
ThisIsMani
previously approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes looks fine.
801733d
…-and-authentication-data-from-processors
…uthentication-data-from-processors
hrithikesh026
previously approved these changes
Mar 19, 2024
…uthentication-data-from-processors
sai-harsha-vardhan
approved these changes
Mar 19, 2024
ThisIsMani
approved these changes
Mar 19, 2024
sahkal
approved these changes
Mar 20, 2024
hrithikesh026
approved these changes
Mar 20, 2024
ArjunKarthik
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds the capability to store
payment_checks
andauthentication_data
( threeds data ) sent from processorsAdditional Changes
The payments response for card now looks like ( for stripe connector only ).
authentication_data
is present for cards only.payment_checks
is present for all stripe card payments.Motivation and Context
These data are required to do fraud check analysis when a dispute is raised
How did you test it?
no_three_ds
payment with stripe connector.payment_method_data.card.payment_checks
is presentthree_ds
payment and complete the redirectionpayment_method_data.card.authentication_data
is present and is in the below format.Impact
Checklist
cargo +nightly fmt --all
cargo clippy