Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(access_token): use fallback to connector_name if merchant_connector_id is not present #4503

Merged
merged 1 commit into from
May 1, 2024
Merged

fix(access_token): use fallback to connector_name if merchant_connector_id is not present #4503

merged 1 commit into from
May 1, 2024

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • Bugfix

Description

This PR adds a fallback to use connector_name in cases where merhant_connector_id is not available.

Motivation and Context

How did you test it?

  • Run the postman tests for paypal and trustpay connectors

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 added the C-bug Category: Bug label Apr 30, 2024
@Narayanbhat166 Narayanbhat166 added this to the April 2024 milestone Apr 30, 2024
@Narayanbhat166 Narayanbhat166 self-assigned this Apr 30, 2024
@Narayanbhat166 Narayanbhat166 requested review from a team as code owners April 30, 2024 08:06
@Narayanbhat166 Narayanbhat166 linked an issue Apr 30, 2024 that may be closed by this pull request
[REFACTOR]: use merchant_connector_id for storing access_token #4461
Closed
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 632a00c May 1, 2024
12 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix_access_token_multiple_mca branch May 1, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahkal sahkal sahkal approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@vspecky vspecky Awaiting requested review from vspecky

Assignees

@Narayanbhat166 Narayanbhat166

Labels
C-bug Category: Bug
Projects
None yet
Milestone
April 2024 Release
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: use merchant_connector_id for storing access_token
4 participants
@Narayanbhat166 @sahkal @sai-harsha-vardhan @Gnanasundari24