Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): change primary keys in payment_methods table #5393

Merged
merged 10 commits into from
Jul 22, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Jul 22, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Changing the primary key of the payment_methods table from (id) to the payment_method_id.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Required for api_v2 migration

How did you test it?

Just Db id migration, doesn't requires any specific testing

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner July 22, 2024 08:39
@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft July 22, 2024 08:39
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Jul 22, 2024
@prajjwalkumar17 prajjwalkumar17 changed the title Db/migrations for v2 refactor(core): change primary keys in payment_methods table Jul 22, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Jul 22, 2024
@Narayanbhat166 Narayanbhat166 marked this pull request as ready for review July 22, 2024 09:47
@prajjwalkumar17 prajjwalkumar17 added this to the July 2024 Release milestone Jul 22, 2024
@prajjwalkumar17 prajjwalkumar17 linked an issue Jul 22, 2024 that may be closed by this pull request
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit ca749b3 Jul 22, 2024
23 of 28 checks passed
@likhinbopanna likhinbopanna deleted the db/migrations_for_v2 branch July 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: change primary key of payment_methods table for v2
5 participants