refactor(id_type): use macros for defining ID types and implementing common traits #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function to construct ID types
SanchithHegde
added
S-waiting-on-review
Narayanbhat166
previously approved these changes
Jul 30, 2024
srujanchikke
previously approved these changes
Jul 30, 2024
Aprabhat19
previously approved these changes
Jul 30, 2024
ThisIsMani
previously approved these changes
Jul 30, 2024
lsampras
previously approved these changes
Jul 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jarnura
previously approved these changes
Jul 30, 2024
SanchithHegde
dismissed stale reviews from jarnura, lsampras, ThisIsMani, Aprabhat19, srujanchikke, and Narayanbhat166
via
d4ca69e
jarnura
approved these changes
Jul 30, 2024
Narayanbhat166
approved these changes
Jul 30, 2024
ThisIsMani
approved these changes
Jul 30, 2024
Aprabhat19
approved these changes
Jul 30, 2024
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces declarative macros to define ID types and implement common traits such as
Debug,FromSql,ToSql, etc. on these ID types. In addition, this PR replaces the usages of thefrom()associated function (to construct the ID types) with theTryFromtrait implementation.Motivation and Context
Helps reduce duplication of boilerplate code.
How did you test it?
Sanity testing using Postman collection, code should work if it compiles.
Checklist
cargo +nightly fmt --allcargo clippy