Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing): add domain type for Routing id #5733

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented Aug 28, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add domain type for Routing id

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

Create, Update & Retrieve of outing and subsequent flows like payments sanity

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Aprabhat19 Aprabhat19 requested review from a team as code owners August 28, 2024 11:10
Copy link

semanticdiff-com bot commented Aug 28, 2024

Review changes with SemanticDiff.

Analyzed 13 of 14 files.

Overall, the semantic diff is 23% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/routes/routing.rs Analyzed
✔️ crates/router/src/db/kafka_store.rs Analyzed
✔️ crates/router/src/db/routing_algorithm.rs 0.0% smaller
✔️ crates/router/src/core/admin.rs Analyzed
✔️ crates/router/src/core/routing.rs 50.22% smaller
✔️ crates/router/src/core/payments/routing.rs 0.0% smaller
✔️ crates/hyperswitch_domain_models/src/business_profile.rs Analyzed
✔️ crates/diesel_models/src/business_profile.rs 0.0% smaller
✔️ crates/diesel_models/src/routing_algorithm.rs 0.0% smaller
✔️ crates/diesel_models/src/query/routing_algorithm.rs 0.0% smaller
✔️ crates/common_utils/src/id_type.rs Analyzed
✔️ crates/common_utils/src/lib.rs Analyzed
crates/common_utils/src/id_type/routing.rs Unsupported file format
✔️ crates/api_models/src/routing.rs 32.28% smaller

@Aprabhat19 Aprabhat19 self-assigned this Aug 28, 2024
@Aprabhat19 Aprabhat19 removed the request for review from a team August 29, 2024 08:58
@Aprabhat19 Aprabhat19 linked an issue Aug 29, 2024 that may be closed by this pull request
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit e939db2 Aug 29, 2024
18 checks passed
@Gnanasundari24 Gnanasundari24 deleted the routing-id-type branch August 29, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] add domain type for routing id
5 participants