Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kine to v0.13.10 (to fix a bug introduced in v0.13.4) #5593

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

svanharmelen
Copy link
Contributor

@svanharmelen svanharmelen commented Feb 20, 2025

Description

Kine v0.13.4 introduced a small bug which we hit when updating to k0s version v1.32.1+k0s.0 (and made us revert the update for now). The main issue and the fix is described in this PR which is included in the latest release (v0.13.10): k3s-io/kine#414

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@svanharmelen svanharmelen requested review from a team as code owners February 20, 2025 15:55
@svanharmelen svanharmelen requested review from ncopa and twz123 February 20, 2025 15:55
@twz123 twz123 enabled auto-merge February 20, 2025 22:41
@twz123 twz123 disabled auto-merge February 20, 2025 22:41
@twz123 twz123 added bug Something isn't working area/controlplane component/kine backport/release-1.32 PR that needs to be backported/cherrypicked to release-1.32 branch labels Feb 20, 2025
@twz123
Copy link
Member

twz123 commented Feb 20, 2025

Thanks 🚀

@twz123 twz123 merged commit b384128 into k0sproject:main Feb 20, 2025
98 checks passed
@k0s-bot
Copy link

k0s-bot commented Feb 20, 2025

Successfully created backport PR for release-1.32:

@svanharmelen
Copy link
Contributor Author

Thanks for merging the PR @twz123! Do you have any (rough) idea when a new release will be made which will include this fix? We temperately rolled back some of our changes (which included the k0s release) so are looking forward to be able to rollout the changes again using an updated version of k0s. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controlplane backport/release-1.32 PR that needs to be backported/cherrypicked to release-1.32 branch bug Something isn't working component/kine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants