Fix: unable to import image Darwin/arm64 #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
requested changes
Jan 15, 2023
|
Sorry for the late review. Ready to merge with the correct module name 👍 |
Signed-off-by: qiaozp <[email protected]>
|
@iwilltry42 Hey, sorry for the late reply. Just had a vacation. I have revert the module name. PTAL. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In Darwin/arm64 platform, k3d can not correctly import image to cluster. In this PR, I add
--all-platformsarguments forctr image importto fix it.Why
It is an essential function for k3d. We should fix the bug. Related issues: #954, #1072
Implications