fixing the makefile; enforcing the registry port match; #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
approved these changes
Feb 12, 2025
| @@ -83,7 +91,7 @@ func ParsePortExposureSpec(exposedPortSpec, internalPort string) (*k3d.ExposureO | |||
| } | |||
|
|
|||
| // port: get a free one if there's none defined or set to random | |||
| if submatches["port"] == "" || submatches["port"] == "random" { | |||
There was a problem hiding this comment.
because it's dead code, that case is already handled in the line 50.
There was a problem hiding this comment.
Fair - didn't see that in the reduced PR view 👍
iwilltry42
approved these changes
Feb 12, 2025
| @@ -83,7 +91,7 @@ func ParsePortExposureSpec(exposedPortSpec, internalPort string) (*k3d.ExposureO | |||
| } | |||
|
|
|||
| // port: get a free one if there's none defined or set to random | |||
| if submatches["port"] == "" || submatches["port"] == "random" { | |||
There was a problem hiding this comment.
Fair - didn't see that in the reduced PR view 👍
|
Thanks for this enhancement! |
|
@yakom @iwilltry42 I suspect that this change broke ligfx/k3d-registry-dockerd#13 (comment). Can you please take a quick look? |
|
This change also broke my CI pipeline, downgrading to 5.8.1 solves it. |
|
FYI: I reverted this and pushed v5.8.3 - we'll re-introduce this change (maybe slightly adjusted) including more docs and more verbose release notes again at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makefile changes make sure that the vendor directory is used by the build process (the
GOFLAGSchange) as well as that the local cache isn't needlessly built (both changes) - since there is the said directory.the code changes fix issue 1406, making sure that the internal and external listening ports of the registries match if they are set to a non-default value (and that the Docker port mapping of the registry container is set up correctly as well).
when i run the E2E tests locally, 8 of them are failing for a seemingly unrelated reason. i'd like to be able to see the CI test execution output.