[FEATURE] add ability to add ports to an existing loadbalancer #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the functionality to edit existing nodes.
Primary use case for the ALPHA is adding new port-mappings to existing nodes, primarily the loadbalancer (as it is stateless, making it easier to handle the recreation).
How
We compile a changeset (basically a new node, with only the newly added fields filled), which we add to a copy of the selected target node (with stripped out status fields).
Then we rename the existing/old node, create the new one, stop the old one, start the new one, delete the old one.
If anything goes wrong in the middle of the process, then we'll try to rollback to having the old node ready as before (same name, same ports, etc.).
Why
This allows us to add new port-mappings (and hopefully more at some point) to an existing cluster, e.g. if one forgot to map the http/https ports for ingress when creating the cluster or if there's a new nodePort present, etc.
Change Overview
CLI
k3d node edit NODENAME
--port-add [HOSTPORT:]CONTAINERPORT[/PROTOCOL]
k3d node edit k3d-mycluster-serverlb --port-add 8080:80
to add http port mapping for ingress after creating the clusterpkg
NodeEdit
To-Do
Related Issues
#6 (though far from what was discussed there)