-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] host pid mode support for k3s-server and k3s-agent #929
Conversation
Signed-off-by: hlts2 <[email protected]>
The test seems to be failing, but when I executed
cc: @iwilltry42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hlts2, thanks for your contribution! :)
Looks simple and good. I just have one comment about structuring the config, as I think this option belongs to the runtime
options.
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tests are passing for me (actually I can't get them to fail like they do in CI, but that's unrelated to this PR anyway). Thank you! |
What
To support eBPF profile, I added an option to support host pid mode for k3s-agent and k3s-server.
The following is an example of usage.
Why
In order to enable eBPF in docker environment, the option
pid=host
is required.I deployed the manifest(pyroscope) to a k3d cluster, but could not get the eBPF event properly because k3s-server and k3s-agent docker container were not started in host pid mode.
With this PR fix, k3s-server and k3s-agent will be started in host pid mode, so eBPF will be available in the k3d environment.