closes #609 Golangci-lint has been greatly expanded with new linter types, some of which I have integrated. With the new linters came also changes in the code, mainly - introduction of constants for repeating text - throwing out deprecated code Some of the linters were not suitable and have been commented out - golint is deprecated, revive is instead - whitespace - it's bad to have empty lines in the code, in my opinion it degrades clarity - funlen - watches the length of functions and their names - exhaustive - completing missing constants in the switch (not only default) - gomnd - force to have any number in constant. E.g. mark if len(x) > 2 , - gofmt - is part of goimports I had to change linter configuration for these: - gochecknoinits - it is bothered by wrong use of init function - it is only init() in generated code - dupl - duplicates in the code (this only applies to testing, where duplicates happen frequently. We don't mind it there) In addition I updated build pipeline. Signed-off-by: kuritka <kuritka@gmail.com>

Bump GOLANGCI-LINT #609

Description

Activity

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions