Skip to content

Consider a depressolver implemented against the interface #908

Closed
@kuritka

Description

I've been considering implementing a depressolver against the interface for a long time - mainly because of the generated mocks, which would make testing the GSLB controller much easier. Practice says that you shouldn't change the implementation for testing, but it would be more than appropriate at this point.

if accept the new interface, implement the following steps:

  • the implementation of the Resolver interface
  • refactor
  • modify the tests if necessary
  • generate MOCK

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions