Consume coredns crd plugin with WRR functionality #1141
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,13 +11,12 @@ data: | |
| errors | ||
| health | ||
| ready | ||
| prometheus 0.0.0.0:9153 | ||
| forward . /etc/resolv.conf | ||
| k8s_crd { | ||
| filter k8gb.absa.oss/dnstype=local | ||
| negttl {{ .Values.k8gb.dnsZoneNegTTL }} | ||
| loadbalance weight | ||
|
There was a problem hiding this comment. isn't it hardcoding particular method? There was a problem hiding this comment. Would be great to get confirmation from @kuritka , but if I understand correctly it does standard round-robin if no WRR in Gslb spec, see k8gb-io/coredns-crd-plugin#45 There was a problem hiding this comment. Hi @ytsarev, RR is only a subset of WRR. If weights are not defined , the RR is automatically applied. If weights are defined in CR, the WRR is used. If an error occurs for any reason, then the RR is used automatically. tahts what The reason why I defines this field is for extendability. I was planning that in the future there will be a |
||
| } | ||
| } | ||
| {{- end }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuritka it's not immediately clear from k8gb-io/coredns-crd-plugin#45 - why do we need to remove this config line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources DNSEndpointfield was meaningless, we didn't work with it in any way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuritka cool, I was mostly wondering why it actually breaking the terratest, but cool to get rid of it any case, thanks!