Make project lintable from project's root #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves 131 - remove redundant `zz_generated.openapi.go` - add comments to public members required by `golint` - remove redundant references from `go.mod` - remove `GOLINTPATH` in `build.yaml` will cause `GOLINTPATH` will be set to `.` or better `(./...)` - fix test in `Makefile` to run all unitests (terratest is ignored as it has no any reference to main) - merge `version.go` Than we can - golint ./... from the project root
ytsarev
approved these changes
May 24, 2020
|
LGTM |
somaritane
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131
zz_generated.openapi.gogolintgo.modGOLINTPATHinbuild.yamlcausesGOLINTPATHwill be set to.or better(./...)Makefileto run all unitests (terratest is ignored as it has no any reference to main)version.goThan we can